task: spectral - minor changes in readme and dev setup #472
Conversation
tools/spectral/Makefile
Outdated
| @echo "==> Running spectral linter" | ||
| npx -- @stoplight/spectral-cli@"${SPECTRAL_VERSION}" lint ../../openapi/v2.yaml --ruleset=.spectral.yaml --fail-severity=warn | ||
|
|
||
| ## IPA sepecific targets |
There was a problem hiding this comment.
Ideally we should not use make but wanted to add targets for completeness and simplicity of onboarding.
There was a problem hiding this comment.
I don't think we need to add the IPA targets here since we have the package.json, this Makefile is for the legacy Spectral we have. I think I'd prefer if we move these to the package.json instead
There was a problem hiding this comment.
my two cents from the outside is that i'd love to see a makefile to quickly catch up since other tools also have makefiles (no strong opinion)
There was a problem hiding this comment.
Do you know if we use Make those in dowstream?
There was a problem hiding this comment.
For now I will remove those changes and we can have follow up PR to cover removal of MAKE (likely needs more than just this PR and discussion
wtrocki
force-pushed
the
task-minor-docs-updates
branch
from
2f6cfad to
2dc9b51
Compare
3 participants
Couple drivebys while I'm reviewing the codebase: